Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

[Richard Henderson]

On 05/24/2010 09:19 AM, Nathan Froyd wrote:
> +    case FMT_D:                                                              
>  \
> +        if (abs)                                                             
>  \
> +            check_cop1x(ctx);                                                
>  \
> +        check_cp1_registers(ctx, fs | ft);                                   
>  \
> +        break;                                                               
>  \
> +    case FMT_S:                                                              
>  \
> +        if (abs)                                                             
>  \
> +            check_cop1x(ctx);                                                
>  \

Coding style.

> +    switch (n) {                                                             
>  \
> +    case  0: gen_helper_2i(cmp ## type ## _ ## fmt ## _f, fp0, fp1, cc);    
> break;\
> +    case  1: gen_helper_2i(cmp ## type ## _ ## fmt ## _un, fp0, fp1, cc);   
> break;\
> +    case  2: gen_helper_2i(cmp ## type ## _ ## fmt ## _eq, fp0, fp1, cc);   
> break;\
> +    case  3: gen_helper_2i(cmp ## type ## _ ## fmt ## _ueq, fp0, fp1, cc);  
> break;\
> +    case  4: gen_helper_2i(cmp ## type ## _ ## fmt ## _olt, fp0, fp1, cc);  
> break;\
> +    case  5: gen_helper_2i(cmp ## type ## _ ## fmt ## _ult, fp0, fp1, cc);  
> break;\
> +    case  6: gen_helper_2i(cmp ## type ## _ ## fmt ## _ole, fp0, fp1, cc);  
> break;\
> +    case  7: gen_helper_2i(cmp ## type ## _ ## fmt ## _ule, fp0, fp1, cc);  
> break;\
> +    case  8: gen_helper_2i(cmp ## type ## _ ## fmt ## _sf, fp0, fp1, cc);   
> break;\
> +    case  9: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngle, fp0, fp1, cc); 
> break;\
> +    case 10: gen_helper_2i(cmp ## type ## _ ## fmt ## _seq, fp0, fp1, cc);  
> break;\
> +    case 11: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngl, fp0, fp1, cc);  
> break;\
> +    case 12: gen_helper_2i(cmp ## type ## _ ## fmt ## _lt, fp0, fp1, cc);   
> break;\
> +    case 13: gen_helper_2i(cmp ## type ## _ ## fmt ## _nge, fp0, fp1, cc);  
> break;\
> +    case 14: gen_helper_2i(cmp ## type ## _ ## fmt ## _le, fp0, fp1, cc);   
> break;\
> +    case 15: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngt, fp0, fp1, cc);  
> break;\

I wonder if this wouldn't be better structured as a table lookup?


r~