qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte di


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements
Date: Fri, 4 Jun 2010 20:03:39 +0000

Thanks, applied.

On Fri, Jun 4, 2010 at 4:23 PM, Richard Henderson <address@hidden> wrote:
> On 06/04/2010 07:27 AM, Paolo Bonzini wrote:
>> Negative four byte displacements need to be sign-extended after
>> c086b783eb7a578993d6d2ab62c4c2666800b63d.  Do so.
>
> Acked-by: Richard Henderson  <address@hidden>
>
>
>>         There are quite a few other ldl's to audit after the patch
>>         (about 70 in target-*).  Any volunteers? :-)
>
> I've looked over all the uses of ldl_code.  Thankfully 95% of them
> are immediately stored into an explicit 32-bit variable.  I do not
> see any other problematic uses of that particular identifier.
>
>
> r~
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]