[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte di
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements |
Date: |
Fri, 4 Jun 2010 20:03:39 +0000 |
Thanks, applied.
On Fri, Jun 4, 2010 at 4:23 PM, Richard Henderson <address@hidden> wrote:
> On 06/04/2010 07:27 AM, Paolo Bonzini wrote:
>> Negative four byte displacements need to be sign-extended after
>> c086b783eb7a578993d6d2ab62c4c2666800b63d. Do so.
>
> Acked-by: Richard Henderson <address@hidden>
>
>
>> There are quite a few other ldl's to audit after the patch
>> (about 70 in target-*). Any volunteers? :-)
>
> I've looked over all the uses of ldl_code. Thankfully 95% of them
> are immediately stored into an explicit 32-bit variable. I do not
> see any other problematic uses of that particular identifier.
>
>
> r~
>
- Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking, (continued)
- [Qemu-devel] [PATCH 3/8] sparc64: fix 32bit load sign extension, Igor V. Kovalenko, 2010/06/01
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Alexander Graf, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Igor Kovalenko, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/04
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/04
- [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements, Paolo Bonzini, 2010/06/04
- Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements, Richard Henderson, 2010/06/04
- Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements,
Blue Swirl <=
[Qemu-devel] [PATCH 4/8] sparc64: fix ldxfsr insn, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 5/8] sparc64: use symbolic name for MMU index, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 6/8] sparc64: improve ldf and stf insns, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 8/8] sparc64: fix umul and smul insns, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 7/8] sparc64: fix udiv and sdiv insns, Igor V. Kovalenko, 2010/06/01
Re: [Qemu-devel] [PATCH 0/8] sparc64 fixes, Blue Swirl, 2010/06/02