Re: [Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server

[Corentin Chary]

On Sun, Jun 6, 2010 at 3:54 PM, Avi Kivity <address@hidden> wrote:
> On 06/05/2010 11:03 AM, Corentin Chary wrote:
>>>
>>> So it's disabled by default? Sounds like a pretty cool and useful feature
>>> to me that should be enabled by default.
>>>
>>
>> Because it's does not work on  windows (qemu-thread.c only uses
>> pthread) and because I don't want to break everything :)
>>
>
> One option is to disable vnc on Windows and let a Windows maintainer
> materialize and add the corresponding support.  Introducing more and more
> config options is not a good approach.

I think keeping the non-threaded code is a good thing (and there is
not much code). There is probably case where you want to avoid
threads.



-- 
Corentin Chary
http://xf.iksaif.net