[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/6] vnc: add lossy option
From: |
Corentin Chary |
Subject: |
[Qemu-devel] [PATCH v2 3/6] vnc: add lossy option |
Date: |
Mon, 7 Jun 2010 08:08:06 +0200 |
The lossy option can be used to enable lossy compression
methods like gradient or jpeg. This patch disable them by
default.
Signed-off-by: Corentin Chary <address@hidden>
---
qemu-options.hx | 7 +++++++
vnc-encoding-tight.c | 4 ++++
vnc.c | 2 ++
vnc.h | 2 ++
4 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index a6928b7..cf33a54 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -828,6 +828,13 @@ empty, with a @code{deny} policy. Thus no one will be
allowed to
use the VNC server until the ACLs have been loaded. This can be
achieved using the @code{acl} monitor command.
address@hidden lossy
+
+Enable lossy compression methods (gradient, JPEG, ...). If this
+option is set, VNC client may receive lossy framebuffer updates
+depending on its encoding settings. Enabling this option can save
+a lot of bandwidth at the expense of quality.
+
@end table
ETEXI
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index 495745e..4257bd0 100644
--- a/vnc-encoding-tight.c
+++ b/vnc-encoding-tight.c
@@ -230,6 +230,10 @@ tight_detect_smooth_image(VncState *vs, int w, int h)
int compression = vs->tight_compression;
int quality = vs->tight_quality;
+ if (!vs->vd->lossy) {
+ return 0;
+ }
+
if (ds_get_bytes_per_pixel(vs->ds) == 1 ||
vs->clientds.pf.bytes_per_pixel == 1 ||
w < VNC_TIGHT_DETECT_MIN_WIDTH || h < VNC_TIGHT_DETECT_MIN_HEIGHT) {
diff --git a/vnc.c b/vnc.c
index 9cf38d1..ccd7aad 100644
--- a/vnc.c
+++ b/vnc.c
@@ -2482,6 +2482,8 @@ int vnc_display_open(DisplayState *ds, const char
*display)
#endif
} else if (strncmp(options, "acl", 3) == 0) {
acl = 1;
+ } else if (strncmp(options, "lossy", 5) == 0) {
+ vs->lossy = true;
}
}
diff --git a/vnc.h b/vnc.h
index 2a9024d..ec90cd3 100644
--- a/vnc.h
+++ b/vnc.h
@@ -33,6 +33,7 @@
#include "monitor.h"
#include "audio/audio.h"
#include <zlib.h>
+#include <stdbool.h>
#include "keymaps.h"
@@ -111,6 +112,7 @@ struct VncDisplay
char *display;
char *password;
int auth;
+ bool lossy;
#ifdef CONFIG_VNC_TLS
int subauth; /* Used by VeNCrypt */
VncDisplayTLS tls;
--
1.7.1
- [Qemu-devel] [PATCH v2 0/6] vnc updates and ui move, Corentin Chary, 2010/06/07
- [Qemu-devel] [PATCH v2 2/6] vnc: JPEG should be disabled if the client don't set tight quality, Corentin Chary, 2010/06/07
- [Qemu-devel] [PATCH v2 3/6] vnc: add lossy option,
Corentin Chary <=
- [Qemu-devel] [PATCH v2 4/6] ui: move all ui components in ui/, Corentin Chary, 2010/06/07
- [Qemu-devel] [PATCH v2 5/6] vnc: rename vnc-encoding-* vnc-enc-*, Corentin Chary, 2010/06/07
- [Qemu-devel] [PATCH v2 6/6] vnc: tight: don't forget to add the last color, Corentin Chary, 2010/06/07
- [Qemu-devel] [PATCH v2 1/6] vnc: tight: add JPEG and gradient subencoding with smooth image detection, Corentin Chary, 2010/06/07