[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted |
|
Date: |
Mon, 07 Jun 2010 08:57:12 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Tue, 1 Jun 2010 19:12:19 -0300
> Eduardo Habkost <address@hidden> wrote:
>
>> I have no clue why the code had the is_inserted() check, as it doesn't matter
>> if there is a disk present at the host drive, when the user wants the virtual
>> device to be disconnected from the host device.
>
> Makes sense, although I have no idea if doing a bdrv_close() on a bs which
> doesn't have an image inserted has any side effect.
Should be a no-op.
> Basic testing works as expected, though.
>
> Anyway, I think this should go through the block queue.
Makes sense.