qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.
Date: Mon, 7 Jun 2010 17:12:51 +0100
User-agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; )

> Kill nographic timer.  Have a global gui_timer instead.  Have the gui
> timer enabled unconditionally.  We need a timer running anyway for mmio
> flush, so the whole have-gui-timer-only-when-needed logic is pretty
> pointless.  It also simplifies displaylisteners coming and going at
> runtime, we don't need to care about the timer then as it runs anyway.

Linking mmio flushes to the gui is completely bogus.  The fact that we're 
doing arbitrary periodic mmio flushes suggests something else is horribly 
broken.

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]