[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file="
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] Re: [PATCH] Fix regression for "-drive file=" |
Date: |
Tue, 08 Jun 2010 10:09:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
Am 08.06.2010 09:38, schrieb Markus Armbruster:
> Did this fall through the cracks?
Looks like it. Rebased and applied to the block branch.
Kevin
> Markus Armbruster <address@hidden> writes:
>
>> Empty file used to create an empty drive (no media). Since commit
>> 9dfd7c7a, it's an error: "qemu: could not open disk image : No such
>> file or directory". Older versions of libvirt can choke on this.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> If this goes in, I'll prepare a patch for stable as well.
>>
>> vl.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 85bcc84..78ec1b2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1097,7 +1097,7 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
>> case IF_COUNT:
>> abort();
>> }
>> - if (!file) {
>> + if (!file || !*file) {
>> *fatal_error = 0;
>> return NULL;
>> }
>