[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device I
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs |
Date: |
Tue, 08 Jun 2010 14:06:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Paul Brook <address@hidden> writes:
>> Paul Brook <address@hidden> writes:
>> >> Also require IDs to start with a letter to provide for possible future
>> >> extensions.
>> >
>> > I'd go further than that, and require that user specified IDs match
>> > [A-Za-z][A-Za-z0-9_-]*
>>
>> I talked with Dan (cc'ed) to make sure we don't trample on existing
>> libvirt usage without need. What about
>>
>> [A-Za-z][A-Za-z0-9_-:.]*
>>
>> i.e. your regexp plus ':' and '.' in the second bracket?
>
> I was deliberately avoiding those as they're often used as separators - we
> already use ':' in other contexts so there's potential ambiguity and
> parsing/quoting issues. I'm not aware of any current issues with '.'.
I checked with Dan, and we can outlaw ':'. I just posted a new patch
that covers all qemu-option IDs, not just qdev.
[...]