Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

[Anthony Liguori]

On 06/08/2010 03:03 AM, Gerd Hoffmann wrote:
> >   static QEMUMachine pc_machine = {
> >       .name = "pc-0.13",
> >       .alias = "pc",
> >       .desc = "Standard PC",
> > -    .init = pc_init_pci,
> > +    .init = pc_init,
> >       .max_cpus = 255,
> >       .is_default = 1,
> >       .opts_desc = pc_opts_desc,
> > +    .opts_default = (QemuOptValue[]) {
> > +        {
> > +            .name  = "acpi",
> > +            .value = "on",
> > +        },
>
> Should be moved into a separate struct and just referenced as it is 
> identical for pc-0.*

Would need to be macros because in future patches, things get more 
complicated.  That may be worth it though.

Regards,

Anthony Liguori

> cheers,
>   Gerd