[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

[Juan Quintela]

Yoshiaki Tamura <address@hidden> wrote:
> Hi Juan,
>

> I don't know I have addressed the problem correctly, but here is my
> try to get "info migrate" on incoming side.
>
> http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00417.html

I saw it, haven't had the time to look at it yet.

> Apart from that I have a concern on relation between newly introduced
> QMP Migration events and existing MIG_STATE_*.  Are they supposed to
> be 1 to 1 mapping? 

Good question.  In my tree I had info migrate being the same on
source and destination, but I didn't have async migration.  I have to
check with yours.

> If so, instead of calling
> monitor_protocol_event() everywhere, how about introducing a common
> function in migration that sets s->mig_state and emits QMP Migration
> events at once?

I did that locally, just that this is in the middle of a big cleanup.

I am not sure that is still enough.  We have:

- qemu status: running/stopped
- we have another state "incoming" migration that needs to be same level
  than running/stopped
- I think MIG_STATE_* should also be promotted to this level, but
  haven't fully thought how to do it.

Later, Juan.