Re: [Qemu-devel] [PATCH 05/35] tcg-s390: Icache flush is a no-op.

[Aurelien Jarno]

On Fri, Jun 04, 2010 at 12:14:13PM -0700, Richard Henderson wrote:
> Before gcc 4.2, __builtin___clear_cache doesn't exist, and
> afterward the gcc s390 backend implements it as nothing.

Does it means that instruction and data caches are coherent on s390?

> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  tcg/s390/tcg-target.h |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.h
> index d8a2955..d7fe0c7 100644
> --- a/tcg/s390/tcg-target.h
> +++ b/tcg/s390/tcg-target.h
> @@ -94,9 +94,4 @@ enum {
>  
>  static inline void flush_icache_range(unsigned long start, unsigned long 
> stop)
>  {
> -#if QEMU_GNUC_PREREQ(4, 1)
> -    __builtin___clear_cache((char *) start, (char *) stop);
> -#else
> -#error not implemented
> -#endif
>  }
> -- 
> 1.7.0.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net