Re: [Qemu-devel] [PATCH 3/3] Toggle tracepoint state

[Prerna Saxena]

Hi Luiz,
Thanks for taking time to review it.

On 06/10/2010 02:13 AM, Luiz Capitulino wrote:
> On Tue, 8 Jun 2010 12:38:58 +0530
> Prerna Saxena<address@hidden>  wrote:
>
> > This patch adds support for dynamically enabling/disabling of tracepoints.
> > Monitor commands added :
> > ....
>
>   Monitor has a bool type, please take a look in do_set_link().

Thanks for the pointer. Changed in v2.

> > +    return;
>
>   Not needed, also true for other functions in this patch, suggest reading
> CODING_STYLE for other style related issues in this series.

Done.

> > ....

Hope these commands would make it easy to visualize logged traces via 
the monitor. I'd appreciate feedback on how v2 of the patches posted 
can be enhanced.

--
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India