[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple' trace
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple' trace backend |
Date: |
Fri, 11 Jun 2010 14:08:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Markus Armbruster wrote:
> Prerna Saxena <address@hidden> writes:
>
>> This is v2 of monitor commands based on Stefan's trace framework :
>> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
>>
>> This adds the following monitor commands for the 'simple' backend:
>> - info trace : to view current contents of the trace buffer.
>> - info tracepoints : to view all available tracepoints and their
>> state.
>> - tracepoint NAME on|off: to enable/disable the logging of data from
>> tracepoint 'NAME'.
>>
>>
>> Changelog :
>> - Command 'info trace' is used to view current contents of buffer, in
>> place of 'trace'.
>> - Cleanups
>
> Do we want this in QMP?
For sure IMO. Maybe not in a hurry to avoid breakages until the whole
tracing infrastructure has settled, but long-term to ease scripting etc.
Still, let's not add this as an old-style monitor command, rather
convert it to the new style, maybe blocking QMP for now. I'll post the
required infrastructure for that blocking along my next device_show
series (hopefully the next days).
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux