[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config |
Date: |
Sat, 12 Jun 2010 18:44:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Aurelien Jarno wrote:
> On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
>> Aurelien Jarno wrote:
>>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <address@hidden>
>>>>
>>>> Only match on true dir variable assignments, avoid generating garbage
>>>> due to the "# Configured with: ..." line which may contain "*dir=" as
>>>> well.
>>> Wouldn't it be better to skip all lines starting with '#', as this
>>> problem might happen again after some more changes?
>>>
>>> Or maybe we should do both.
>> This is what the patch (implicitly) does.
>
> Yes, but only for this line. What I mean is something more generic
> like:
>
> "#"*) # comment
> continue
> ;;
>
IMO, that would only paper over suboptimally expressed patterns for the
other line evaluations.
Jan
signature.asc
Description: OpenPGP digital signature