Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

[Paul Brook]

> > And I think we can move the capability setup into init. But this is not
> > directly related to this patch, would just avoid adding this hunk to
> > hpet_reset.
> 
> I actually did that initially and tried to init hpet_cfg there too, but
> then noticed that mmio[0].addr below is not initialized at init time yet.
> 
> > > +    hpet_cfg.hpet.address = sysbus_from_qdev(d)->mmio[0].addr;

This is one of the reasons that you're not supposed to be messing with 
DeviceState contents directly.

Paul