[Qemu-devel] Re: [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

[Nicholas A. Bellinger]

On Mon, 2010-06-14 at 07:42 -0400, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 02:44:31AM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <address@hidden>
> > 
> > This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical
> > to paio_submit() expect that in expected nb_len instead of nb_sectors (* 
> > 512)
> > so that it can be used by BSG AIO for write()/read() of struct sg_io_v4.
> 
> Jusre remove the nb_sectors argument, we already get the length passed
> in the iovec.
> 

Mmmm, should this stay in a seperate paio_submit_len() function..?  Or
would it be preferred to calculate struct qemu_paiocb->aio_nbytes from
the passed iov[i].iov_len for the BlockDriverState->sg == BDS_BSG
case..?

Best,

--nab