[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup |
|
Date: |
Mon, 14 Jun 2010 17:52:04 +0000 |
On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster <address@hidden> wrote:
> Blue Swirl <address@hidden> writes:
>
>> Make APICState completely private to apic.c by using DeviceState
>> in external APIs.
>
> Could you explain why this is an improvement?
Outside of apic.c, there is no need to access APICState fields so we
can remove that privilege. We can move the device instantiation to the
board level where it belongs.