qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.
Date: Mon, 14 Jun 2010 23:52:58 +0100
User-agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.4; x86_64; ; )

> >> This suggests we are incorrectly coalescing writes, and we should
> >> actually be
> >> notifying qemu when (at least) he first write occurs. If we aren't
> >> outputting
> >> anything we don't want to be waking up periodically just to flush an
> >> empty
> >> MMIO buffer.
> > 
> > That is completely unrelated to this patch though.  The patch doesn't
> > change mmio flush behaviour at all.  And the periodic wakeup was there
> > even before the mmio flush patch was added.  Even without gui,
> > although I can't see a obvious reason for it ...
> 
> Agreed.  Regardless of the periodic mmio flush, having a separate
> nographic timer isn't terribly helpful IMHO.

I guess what I was objecting to is formalising this a "gui_timer" rather than 
"arbitrary_polling_hack_timer".

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]