Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include

[Markus Armbruster]

Jan Kiszka <address@hidden> writes:

> Markus Armbruster wrote:
>> Jan Kiszka <address@hidden> writes:
>> 
>>> From: Jan Kiszka <address@hidden>
>>>
>>> Signed-off-by: Jan Kiszka <address@hidden>
>>> ---
>>>  hw/xen_backend.h |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
>>> index f07f7d4..cc25f9d 100644
>>> --- a/hw/xen_backend.h
>>> +++ b/hw/xen_backend.h
>>> @@ -5,6 +5,7 @@
>>>  #include "sysemu.h"
>>>  #include "net.h"
>>>  #include "block_int.h"
>>> +#include "blockdev.h"
>>>  
>>>  /* ------------------------------------------------------------- */
>> 
>> My bad.  Thanks for fixing this!  By the way, Is "block_int.h" really
>> needed here?
>
> Something else broke when I removed it, haven't looked at details though.

Just wondering because exposing block internals in another header file
is *not* nice.