[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix comparison which always returned false
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH] Fix comparison which always returned false |
Date: |
Wed, 16 Jun 2010 01:41:45 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Tue, 15 Jun 2010, Stefan Weil wrote:
This should go in asap, it breaks PPC in quite visible and ugly way...
> Comparing an 8 bit value with ~0 does not work as expected.
> Replace ~0 by UINT8_MAX in comparison and also in assignment
> (and fix coding style, too).
>
> Cc: Gleb Natapov <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/hpet.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/hpet.c b/hw/hpet.c
> index 0c80ee5..d5c406c 100644
> --- a/hw/hpet.c
> +++ b/hw/hpet.c
> @@ -74,7 +74,7 @@ typedef struct HPETState {
> uint8_t hpet_id; /* instance id */
> } HPETState;
>
> -struct hpet_fw_config hpet_cfg = {.count = ~0};
> +struct hpet_fw_config hpet_cfg = {.count = UINT8_MAX};
>
> static uint32_t hpet_in_legacy_mode(HPETState *s)
> {
> @@ -682,8 +682,10 @@ static int hpet_init(SysBusDevice *dev)
> int i, iomemtype;
> HPETTimer *timer;
>
> - if (hpet_cfg.count == ~0) /* first instance */
> + if (hpet_cfg.count == UINT8_MAX) {
> + /* first instance */
> hpet_cfg.count = 0;
> + }
>
> if (hpet_cfg.count == 8) {
> fprintf(stderr, "Only 8 instances of HPET is allowed\n");
>
--
mailto:address@hidden