[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable
From: |
Cam Macdonell |
Subject: |
[Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable |
Date: |
Tue, 15 Jun 2010 16:26:34 -0600 |
On Tue, Jun 15, 2010 at 10:32 AM, Anthony Liguori <address@hidden> wrote:
> On 06/15/2010 11:16 AM, Cam Macdonell wrote:
>>
>> How does this look for marking the device as non-migratable? It adds a
>> field
>> 'no_migrate' to the SaveStateEntry and tests for it in vmstate_save. This
>> would
>> replace anything that touches memory.
>>
>> Cam
>>
>> ---
>> hw/hw.h | 1 +
>> savevm.c | 32 +++++++++++++++++++++++++++++---
>> 2 files changed, 30 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/hw.h b/hw/hw.h
>> index d78d814..7c93f08 100644
>> --- a/hw/hw.h
>> +++ b/hw/hw.h
>> @@ -263,6 +263,7 @@ int register_savevm_live(const char *idstr,
>> void *opaque);
>>
>> void unregister_savevm(const char *idstr, void *opaque);
>> +void mark_no_migrate(const char *idstr, void *opaque);
>>
>
> I'm not thrilled with the name but the functionality is spot on. I lack the
> creativity to offer a better name suggestion :-)
>
> Regards,
>
> Anthony Liguori
Hmmm, in working on this it seems that the memory (from
qemu_ram_map()) is still attached even when the device is removed
(which causes migration to fail because there is an unexpected
memory).
Is something like cpu_unregister_physical_memory()/qemu_ram_free() needed?
Cam
- Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device, (continued)
- Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG., Anthony Liguori, 2010/06/14
- Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG., Cam Macdonell, 2010/06/14
- Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG., Anthony Liguori, 2010/06/14
- [Qemu-devel] [PATCH RFC] Mark a device as non-migratable, Cam Macdonell, 2010/06/15
- [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Anthony Liguori, 2010/06/15
- Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Markus Armbruster, 2010/06/15
- [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable,
Cam Macdonell <=
- Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Anthony Liguori, 2010/06/15
- Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Cam Macdonell, 2010/06/16
- Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Anthony Liguori, 2010/06/16
- Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable, Cam Macdonell, 2010/06/17
[Qemu-devel] Re: [PATCH v6 0/6] Inter-VM Shared Memory Device with migration support, Cam Macdonell, 2010/06/11