[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 01/16] vnc: tight: add JPEG and gradient subenco
From: |
Corentin Chary |
Subject: |
[Qemu-devel] Re: [PATCH 01/16] vnc: tight: add JPEG and gradient subencoding with smooth image detection |
Date: |
Wed, 16 Jun 2010 15:56:34 +0200 |
On Wed, Jun 16, 2010 at 3:18 PM, Juan Quintela <address@hidden> wrote:
> Corentin Chary <address@hidden> wrote:
>> Add gradient filter and JPEG compression with an heuristic to detect how
>> lossy the comppression will be. This code has been adapted from
>> libvncserver/tight.c.
>>
>> JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg
>> and --disable-vnc-jpeg.
>>
>> Signed-off-by: Corentin Chary <address@hidden>
>> ---
>> Makefile.target | 1 +
>> configure | 33 +++
>> vnc-encoding-tight.c | 559
>> +++++++++++++++++++++++++++++++++++++++++++++++++-
>> vnc-encoding-tight.h | 5 +
>> vnc.h | 4 +
>> 5 files changed, 601 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 478b89d..d9e888a 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -177,6 +177,7 @@ LIBS+=-lz
>>
>> QEMU_CFLAGS += $(VNC_TLS_CFLAGS)
>> QEMU_CFLAGS += $(VNC_SASL_CFLAGS)
>> +QEMU_CFLAGS += $(VNC_JPEG_CFLAGS)
>>
>> # xen backend driver support
>> obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>> diff --git a/configure b/configure
>> index c0d8aa5..304b4b0 100755
>> --- a/configure
>> +++ b/configure
>> @@ -268,6 +268,7 @@ uuid=""
>> vde=""
>> vnc_tls=""
>> vnc_sasl=""
>> +vnc_jpeg=""
>
> init it to "no"
>
>> xen=""
>> linux_aio=""
>> vhost_net=""
>
>> ##########################################
>> +# VNC JPEG detection
>> +if test "$vnc_jpeg" = "yes" ; then
>
> and use here != "no" as a test as the rest of the conditions, that way
> you only need to look in one place to know what is the default.
>
I guess the same thing apply to PNG and Threaded server. Would it be
ok to send a cumulative patch to fix that ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
- [Qemu-devel] [PATCH 00/16] VNC updates for 0.13, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 02/16] vnc: JPEG should be disabled if the client don't set tight quality, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 06/16] vnc: tight: don't forget do at the last color, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 03/16] vnc: add lossy option, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 05/16] vnc: rename vnc-encoding-* vnc-enc-*, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 04/16] ui: move all ui components in ui/, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 07/16] vnc: tight: remove a memleak in send_jpeg_rect(), Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 09/16] vnc: tight: specific zlib level and filters for each compression level, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 01/16] vnc: tight: add JPEG and gradient subencoding with smooth image detection, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 15/16] vnc: add missing lock for vnc_cursor_define(), Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 08/16] vnc: tight add PNG encoding, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 10/16] vnc: tight: stop using qdict for palette stuff, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 12/16] vnc: fix tight png memory leak, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 11/16] vnc: encapsulate encoding members, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 16/16] vnc: tight: don't limit png rect size, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 13/16] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit, Corentin Chary, 2010/06/16
- [Qemu-devel] [PATCH 14/16] vnc: threaded VNC server, Corentin Chary, 2010/06/16