Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

[Miguel Di Ciurcio Filho]

On Wed, Jun 16, 2010 at 12:22 PM, Chris Lalancette <address@hidden> wrote:
>> > I didn't mention in the commit, but I've looked at libvirt's source
>> > and it is not using 'info snapshots' AFAIK.
>>
>> Anthony, Dan, are you okay with the change then?
>
> Right, exactly as Miguel said, libvirt doesn't use "info snapshots" at all
> at the moment.  One of the reasons we don't use it at present is precisely
> because it doesn't give us information about all disks in-use.
>
> The other reason that we can't use "info snapshots" is that we need to know
> parent information about snapshots. That is, if you take a sequence of
> snapshots:
>

So lets get there, we need to start from somewhere :-D


>>
>> > At the present time, the VM state is always saved in the first block
>> > device that supports snapshots. I could update the patch to make it
>> > clear on the output somehow.
>>
>> Would be nice to make it clear. Something like this maybe:
>>
>>     Snapshot list from ide0-hd0 (VM state image):
>>     [...]
>
> Yes, I also agree this would be a good idea.  When the QMP version of this
> finally gets implemented, we'll want some way to distinguish where the
> VM state is stored as well.
>

I will update the patch as proposed by Kevin and resend.

Regards,

Miguel