[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RESEND] qdev-properties: Fix (u)intXX parsers
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH][RESEND] qdev-properties: Fix (u)intXX parsers |
|
Date: |
Sun, 20 Jun 2010 17:40:35 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 |
On 06/18/2010 09:27 AM, Kevin Wolf wrote:
> scanf calls must not use PRI constants, they have probably the wrong size and
> corrupt memory. We could replace them by SCN ones, but strtol is simpler than
> scanf here anyway. While at it, also fix the parsers to reject garbage after
> the number ("4096xyz" was accepted before).
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/qdev-properties.c | 50
> +++++++++++++++++++++++++++++++++++---------------
> 1 files changed, 35 insertions(+), 15 deletions(-)
Acked-by: Richard Henderson <address@hidden>
r~