Re: [Qemu-devel] [PATCH v4 13/23] monitor: Allow to specify HMP-specifc command arguments

[Markus Armbruster]

Jan Kiszka <address@hidden> writes:

> From: Jan Kiszka <address@hidden>
>
> As we may want to shrink or enhance the argument set used for monitor
> command in HMP mode, add a separate, optional argument string for that
> case. When an HMP request is parsed, this argument string, if available,
> takes precedence over the standard string.
>
> Signed-off-by: Jan Kiszka <address@hidden>

args_type strings are such a crude tool...  I fear having two of them
just breeds inconsistencies.

There's a big difference between QMP and HMP: QMP has only named
parameters, HMP only positional parameters (type 'O' provides named
options within a positional parameter).  I figure the proper way to deal
with this is to define QMP parameters in a data structure (we need that
for self-documentation anyway), then define a mapping from HMP
positional parameters to QMP named parameters.