qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c,


From: Jes Sorensen
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix
Date: Thu, 24 Jun 2010 12:02:35 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Lightning/1.0b2pre Thunderbird/3.0.4

On 06/23/10 16:44, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
> 
> Signed-off-by: Amit Shah <address@hidden>
> ---
>  qemu-config.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

I really don't like exposing all these options in targets where they are
not functional. It would be really nice if we could come up with a
better way to handle this without just exposing them globally.

Cheers,
Jes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]