Re: [Qemu-devel] [PATCH] net: Fix VM start with '-net none'

[Stefan Hajnoczi]

On Tue, Jun 15, 2010 at 9:00 AM, Amit Shah <address@hidden> wrote:
> Commit 50e32ea8f31035877decc10f1075aa0e619e09cb changed the behaviour
> for the return type of net_client_init() when a nic type with no init
> method was specified. 'none' is one such nic type. Instead of returning
> 0, which gets interpreted as an index into the nd_table[] array, we
> switched to returning -1, which signifies an error as well.
>
> That broke VM start with '-net none'. Testing was only done with the
> monitor command 'pci_add', which doesn't fail.

I stumbled across the broken -net none in qemu.git and qemu-kvm.git.
It does a silent exit(1) on startup.

It would be nice to merge this patch.

Stefan