[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/14]: QMP: Replace client argument checker
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/14]: QMP: Replace client argument checker |
Date: |
Thu, 24 Jun 2010 18:48:08 -0300 |
On Thu, 24 Jun 2010 18:33:26 -0300
Luiz Capitulino <address@hidden> wrote:
> Current QMP's client argument checker code is more complex than it should be
> and has a flaw: it ignores unknown arguments.
>
> This series solves both problems by introducing a new, simple and
> ultra-poweful
> argument checker. This wasn't trivial to get right due to the number of errors
> combinations, so review is very appreciated.
>
> changelog
> ---------
>
> v2 -> v3
>
> - Move all input object checking into qmp_check_input_obj()
> - Fix remaining problem with the handling of O-type arguments
> - Small renames suggested by Markus
> - Small cleanup in handle_qmp_command()
Forgot to mention that changes from v2 begin in patch 08, and really relevant
ones in patch 12.
>
> v1 -> v2
>
> - Introduce new iteration API and use it
> - Handle O-type correctly (I hope so)
> - Address several small issues found by Markus
>
- [Qemu-devel] [PATCH 05/14] check-qdict: Introduce test for the new iteration API, (continued)
- [Qemu-devel] [PATCH 05/14] check-qdict: Introduce test for the new iteration API, Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 06/14] QDict: Introduce qdict_get_try_bool(), Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 07/14] Monitor: handle optional '-' arg as a bool, Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 08/14] QMP: New argument checker (first part), Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 09/14] QMP: New argument checker (second part), Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 10/14] QMP: Drop old client argument checker, Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 11/14] QError: Introduce QERR_QMP_EXTRA_MEMBER, Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 13/14] QMP: Drop old input object checking, Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 12/14] QMP: Introduce qmp_check_input_obj(), Luiz Capitulino, 2010/06/24
- [Qemu-devel] [PATCH 14/14] QMP: handle_qmp_command(): Small cleanup, Luiz Capitulino, 2010/06/24
- Re: [Qemu-devel] [PATCH v3 00/14]: QMP: Replace client argument checker,
Luiz Capitulino <=