[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 01/12] scsi: scsi_bus_legacy_handle_cmdline() ca
|
From: |
Christoph Hellwig |
|
Subject: |
[Qemu-devel] Re: [PATCH 01/12] scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers |
|
Date: |
Fri, 25 Jun 2010 21:39:52 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Fri, Jun 25, 2010 at 06:53:21PM +0200, Markus Armbruster wrote:
> None of its callers checks for failure. scsi_hot_add() can crash
> because of that:
>
> (qemu) drive_add 4 if=scsi,format=host_device,file=/dev/sg1
> scsi-generic: scsi generic interface too old
> Segmentation fault (core dumped)
>
> Fix all callers, not just scsi_hot_add().
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] [PATCH 00/12] More block-related fixes and cleanups, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 01/12] scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers, Markus Armbruster, 2010/06/25
- [Qemu-devel] Re: [PATCH 01/12] scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 06/12] qdev: Decouple qdev_prop_drive from DriveInfo, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 12/12] pc: Fix CMOS info for drives defined with -device, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 05/12] blockdev: Clean up automatic drive deletion, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Markus Armbruster, 2010/06/25