qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] require #define NEED_GLOBAL_ENV for files t


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable
Date: Mon, 28 Jun 2010 21:29:33 +0100
User-agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.4; x86_64; ; )

> diff --git a/exec-all.h b/exec-all.h
> index a775582..ebe88ad 100644
> --- a/exec-all.h
> +++ b/exec-all.h
> @@ -353,4 +353,8 @@ extern int singlestep;
>  /* cpu-exec.c */
>  extern volatile sig_atomic_t exit_request;
> 
> +#ifdef NEED_GLOBAL_ENV
> +register CPUState *env asm(AREG0);
> +#endif

Wouldn't it be better to just put this in dyngen-exec.h ?
AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include 
"exec.h".

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]