Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable

[Paolo Bonzini]

On 06/29/2010 01:30 PM, Paul Brook wrote:
> I don't understand what this is supposed to achieve.
> The inclusion of exec.h is what defines whether this global variable is
> available.  Just as importantly, it also prevents code clobbering this value.
> Having one without the other makes no sense.
>
> Making "env" available without including exec.h would be a different problem,
> but we never do that and would probably indicate we're doing something else
> wrong.

Paul, I agree but I was told to do something different.

Paolo