qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] AppleSMC device emulation


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH] AppleSMC device emulation
Date: Tue, 29 Jun 2010 18:38:49 +0000

On Tue, Jun 29, 2010 at 2:35 PM, Alexander Graf <address@hidden> wrote:
> Intel Macs have a chip called the "AppleSMC" which they use to control
> certain Apple specific parts of the hardware, like the keyboard background
> light.
>
> That chip is also used to store a key that Mac OS X uses to decrypt binaries.
>
> This patch adds emulation for that chip, so we're getting one step further
> to having Mac OS X run natively on Qemu.
>
> Signed-off-by: Alexander Graf <address@hidden>
> ---
>  Makefile.target |    2 +-
>  hw/applesmc.c   |  225 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 226 insertions(+), 1 deletions(-)
>  create mode 100644 hw/applesmc.c
>
> diff --git a/Makefile.target b/Makefile.target
> index f64702b..dcf0193 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -192,7 +192,7 @@ obj-y += e1000.o
>  obj-i386-y += vga.o
>  obj-i386-y += mc146818rtc.o i8259.o pc.o
>  obj-i386-y += cirrus_vga.o apic.o ioapic.o piix_pci.o
> -obj-i386-y += vmmouse.o vmport.o hpet.o
> +obj-i386-y += vmmouse.o vmport.o hpet.o applesmc.o
>  obj-i386-y += device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o
>  obj-i386-y += debugcon.o multiboot.o
>  obj-i386-y += pc_piix.o
> diff --git a/hw/applesmc.c b/hw/applesmc.c
> new file mode 100644
> index 0000000..572b8f7
> --- /dev/null
> +++ b/hw/applesmc.c
> @@ -0,0 +1,225 @@
> +/*
> + *  Apple SMC controller
> + *
> + *  Copyright (c) 2007 Alexander Graf
> + *
> + *  Authors: Alexander Graf <address@hidden>
> + *           Susanne Graf <address@hidden>
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

Please use the modern version with 'if not, see <http://www.gnu.org/licenses/>.'

> + *
> + * *****************************************************************
> + *
> + * In all Intel-based Apple hardware there is an SMC chip to control the
> + * backlight, fans and several other generic device parameters. It also
> + * contains the magic keys used to dongle Mac OS X to the device.
> + *
> + * This driver was mostly created by looking at the Linux AppleSMC driver
> + * implementation and does not support IRQ.
> + *
> + */
> +
> +#include "hw.h"
> +#include "isa.h"
> +#include "console.h"
> +#include "qemu-timer.h"
> +
> +#define DEBUG_SMC
> +
> +#define APPLESMC_DEFAULT_IOBASE        0x300
> +/* data port used by Apple SMC */
> +#define APPLESMC_DATA_PORT             0x0
> +/* command/status port used by Apple SMC */
> +#define APPLESMC_CMD_PORT              0x4
> +#define APPLESMC_NR_PORTS              32
> +#define APPLESMC_MAX_DATA_LENGTH       32
> +
> +#define APPLESMC_READ_CMD              0x10
> +#define APPLESMC_WRITE_CMD             0x11
> +#define APPLESMC_GET_KEY_BY_INDEX_CMD  0x12
> +#define APPLESMC_GET_KEY_TYPE_CMD      0x13
> +
> +#ifdef DEBUG_SMC
> +#define smc_debug(...) printf(__VA_ARGS__)

How about:
#define smc_debug(fmt, ...) printf("APPLESMC: " fmt, ## __VA_ARGS__)

> +#else
> +#define smc_debug(...) do { } while(0)
> +#endif
> +
> +static char default_osk[64] = "This is a dummy key. Enter the real key "
> +                              "using the -osk parameter";
> +
> +struct AppleSMCData {
> +    uint8_t len;
> +    const char *key;
> +    const char *data;
> +    QLIST_ENTRY(AppleSMCData) node;
> +};
> +
> +struct AppleSMCStatus {
> +    ISADevice dev;
> +    uint32_t iobase;
> +    uint8_t cmd;
> +    uint8_t status;
> +    uint8_t key[4];
> +    uint8_t read_pos;
> +    uint8_t data_len;
> +    uint8_t data_pos;
> +    uint8_t data[255];
> +    uint8_t charactic[4];
> +    char *osk;
> +    QLIST_HEAD(, AppleSMCData) data_def;
> +};
> +
> +static void applesmc_io_cmd_writeb(void *opaque, uint32_t addr, uint32_t val)
> +{
> +    struct AppleSMCStatus *s = (struct AppleSMCStatus *)opaque;

Useless cast in C, also in other places.

> +    smc_debug("APPLESMC: CMD Write B: %#x = %#x\n", addr, val);
> +    switch(val) {
> +        case APPLESMC_READ_CMD:
> +            s->status = 0x0c;
> +            break;
> +    }
> +    s->cmd = val;
> +    s->read_pos = 0;
> +    s->data_pos = 0;
> +}
> +
> +static void applesmc_fill_data(struct AppleSMCStatus *s)
> +{
> +    struct AppleSMCData *d;
> +
> +    QLIST_FOREACH(d, &s->data_def, node) {
> +        uint32_t key_data = *((uint32_t*)d->key);
> +        uint32_t key_current = *((uint32_t*)s->key);
> +        if(key_data == key_current) {

I'd use memcmp(). There's no space between 'if' and '('.

> +            smc_debug("APPLESMC: Key matched (%s Len=%d Data=%s)\n", d->key,
> +                      d->len, d->data);
> +            memcpy(s->data, d->data, d->len);
> +            return;
> +        }
> +    }
> +}
> +
> +static void applesmc_io_data_writeb(void *opaque, uint32_t addr, uint32_t 
> val)
> +{
> +    struct AppleSMCStatus *s = (struct AppleSMCStatus *)opaque;
> +    smc_debug("APPLESMC: DATA Write B: %#x = %#x\n", addr, val);
> +    switch(s->cmd) {
> +        case APPLESMC_READ_CMD:
> +            if(s->read_pos < 4) {
> +                s->key[s->read_pos] = val;
> +                s->status = 0x04;
> +            } else if(s->read_pos == 4) {
> +                s->data_len = val;
> +                s->status = 0x05;
> +                s->data_pos = 0;
> +                smc_debug("APPLESMC: Key = %c%c%c%c Len = %d\n", s->key[0],
> +                          s->key[1], s->key[2], s->key[3], val);
> +                applesmc_fill_data(s);
> +            }
> +            s->read_pos++;
> +            break;
> +    }
> +}
> +
> +static uint32_t applesmc_io_data_readb(void *opaque, uint32_t addr1)
> +{
> +    struct AppleSMCStatus *s = (struct AppleSMCStatus *)opaque;
> +    uint8_t retval = 0;
> +    switch(s->cmd) {
> +        case APPLESMC_READ_CMD:
> +            if(s->data_pos < s->data_len) {
> +                retval = s->data[s->data_pos];
> +                smc_debug("APPLESMC: READ_DATA[%d] = %#hhx\n", s->data_pos,
> +                          retval);
> +                s->data_pos++;
> +                if(s->data_pos == s->data_len) {
> +                    s->status = 0x00;
> +                    smc_debug("APPLESMC: EOF\n");
> +                } else
> +                    s->status = 0x05;
> +            }
> +    }
> +    smc_debug("APPLESMC: DATA Read b: %#x = %#x\n", addr1, retval);
> +    return retval;
> +}
> +
> +static uint32_t applesmc_io_cmd_readb(void *opaque, uint32_t addr1)
> +{
> +    smc_debug("APPLESMC: CMD Read B: %#x\n", addr1);
> +    return ((struct AppleSMCStatus*)opaque)->status;

I'd add a variable to avoid the cast.

> +}
> +
> +static void applesmc_add_key(struct AppleSMCStatus *s, const char *key,
> +                             int len, const char *data)
> +{
> +    struct AppleSMCData *def;
> +
> +    def = qemu_mallocz(sizeof(struct AppleSMCData));
> +    def->key = key;
> +    def->len = len;
> +    def->data = data;
> +
> +    QLIST_INSERT_HEAD(&s->data_def, def, node);
> +}
> +
> +static int applesmc_isa_init(ISADevice *dev)
> +{
> +    struct AppleSMCStatus *s = DO_UPCAST(struct AppleSMCStatus, dev, dev);
> +
> +    register_ioport_read(s->iobase + APPLESMC_DATA_PORT, 4, 1,
> +                         applesmc_io_data_readb, s);
> +    register_ioport_read(s->iobase + APPLESMC_CMD_PORT, 4, 1,
> +                         applesmc_io_cmd_readb, s);
> +    register_ioport_write(s->iobase + APPLESMC_DATA_PORT, 4, 1,
> +                          applesmc_io_data_writeb, s);
> +    register_ioport_write(s->iobase + APPLESMC_CMD_PORT, 4, 1,
> +                          applesmc_io_cmd_writeb, s);
> +
> +    QLIST_INIT(&s->data_def);
> +
> +    if (!s->osk || (strlen(s->osk) != 64)) {
> +        fprintf(stderr, "WARNING: Using AppleSMC with invalid key\n");
> +        s->osk = default_osk;
> +    }
> +
> +    applesmc_add_key(s, "REV ", 6, "\0x01\0x13\0x0f\0x00\0x00\0x03");
> +    applesmc_add_key(s, "OSK0", 32, s->osk);
> +    applesmc_add_key(s, "OSK1", 32, s->osk + 32);
> +    applesmc_add_key(s, "NATJ", 1, "\0");
> +    applesmc_add_key(s, "MSSP", 1, "\0");
> +    applesmc_add_key(s, "MSSD", 1, "\0x3");

Please add a reset function which sets these, possibly freeing the old
keys. That is, if it is the correct action in reset.

> +
> +    return 0;
> +}
> +
> +static ISADeviceInfo applesmc_isa_info = {
> +    .qdev.name  = "isa-applesmc",
> +    .qdev.size  = sizeof(struct AppleSMCStatus),
> +    .init       = applesmc_isa_init,
> +    .qdev.props = (Property[]) {
> +        DEFINE_PROP_HEX32("iobase", struct AppleSMCStatus, iobase,
> +                          APPLESMC_DEFAULT_IOBASE),
> +        DEFINE_PROP_STRING("osk", struct AppleSMCStatus, osk),
> +        DEFINE_PROP_END_OF_LIST(),
> +    },
> +};
> +
> +static void applesmc_register_devices(void)
> +{
> +    isa_qdev_register(&applesmc_isa_info);
> +}
> +
> +device_init(applesmc_register_devices)
> --
> 1.6.0.2
>
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]