Re: [Qemu-devel] [PATCH] virtio-9p: Fix the memset usage

[Sripathi Kodi]

On Wed, 30 Jun 2010 10:15:29 +0530
"Aneesh Kumar K.V" <address@hidden> wrote:

> The arguments are wrong. Use qemu_mallocz directly
> 
> Signed-off-by: Aneesh Kumar K.V <address@hidden>

Reviewed-by: Sripathi Kodi <address@hidden>

> ---
>  hw/virtio-9p.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
> index 5c5a34b..fba6619 100644
> --- a/hw/virtio-9p.c
> +++ b/hw/virtio-9p.c
> @@ -2782,8 +2782,7 @@ static void v9fs_wstat_post_chown(V9fsState *s, 
> V9fsWstatState *vs, int err)
>      if (vs->v9stat.name.size != 0) {
>       V9fsRenameState *vr;
> 
> -     vr = qemu_malloc(sizeof(V9fsRenameState));
> -     memset(vr, sizeof(*vr), 0);
> +     vr = qemu_mallocz(sizeof(V9fsRenameState));
>       vr->newdirfid= -1;
>       vr->pdu = vs->pdu;
>       vr->fidp = vs->fidp;
> -- 
> 1.7.2.rc0
> 
>