|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups |
Date: | Thu, 1 Jul 2010 16:45:17 +0100 |
User-agent: | KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.4; x86_64; ; ) |
> Since it solves existing problem and is rejected without any rational > explanation and without proposing alternative solution (in form of code) > it should be committed. No. This is not sufficient justification for applying a patch. We should not be accepting patches just because they exist. If a feature[1] is important enough that we need to implement it, then it should also warrant getting a good solution. Otherwise we're going to end up in exactly the same situation next time someone starts using a nwew timesource. Paul [1] Time-drift hacks are a new *feature*, not a bugfix. At best they're hiding more fundamental flaws, e.g. kvm being incapable of emulating realtime behavior.
[Prev in Thread] | Current Thread | [Next in Thread] |