qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, i


From: Kevin Wolf
Subject: [Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind
Date: Mon, 05 Jul 2010 18:00:06 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

Am 30.06.2010 13:55, schrieb Markus Armbruster:
> The two aren't independent variables.  Make that obvious.
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Can we please call the constant IDE_CDROM or something else that is easy
to distinguish? With this patch, we have IDE_CD and IDE_CF, which is an
easy typo to make.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]