[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable |
Date: |
Tue, 6 Jul 2010 14:37:44 +0200 |
Disks without media make no sense. For SCSI, a Linux guest kernel
complains during boot. I didn't try other combinations.
scsi-generic doesn't need the additional check, because it already
requires bdrv_is_sg(), which fails without media.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/ide/core.c | 4 ++++
hw/scsi-disk.c | 5 +++++
hw/virtio-blk.c | 4 ++++
3 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index af52c2c..e20f2e7 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2630,6 +2630,10 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs,
s->drive_kind = IDE_CD;
bdrv_set_change_cb(bs, cdrom_change_cb, s);
} else {
+ if (!bdrv_is_inserted(s->bs)) {
+ error_report("Device needs media, but drive is empty");
+ return -1;
+ }
if (bdrv_is_read_only(bs)) {
error_report("Can't use a read-only drive");
return -1;
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index c30709c..f43f2d0 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -1059,6 +1059,11 @@ static int scsi_disk_initfn(SCSIDevice *dev)
s->bs = s->qdev.conf.bs;
is_cd = bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM;
+ if (!is_cd && !bdrv_is_inserted(s->bs)) {
+ error_report("Device needs media, but drive is empty");
+ return -1;
+ }
+
if (bdrv_get_on_error(s->bs, 1) != BLOCK_ERR_REPORT) {
error_report("Device doesn't support drive option rerror");
return -1;
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 2de1a5a..89ea20e 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -495,6 +495,10 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf
*conf)
error_report("virtio-blk-pci: drive property not set");
return NULL;
}
+ if (!bdrv_is_inserted(conf->bs)) {
+ error_report("Device needs media, but drive is empty");
+ return NULL;
+ }
s = (VirtIOBlock *)virtio_common_init("virtio-blk", VIRTIO_ID_BLOCK,
sizeof(struct virtio_blk_config),
--
1.6.6.1
- [Qemu-devel] [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 8/8] block: Remove type hint, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 7/8] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable,
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 5/8] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 2/8] virtio-blk: Fix virtio-blk-s390 to require drive, Markus Armbruster, 2010/07/06