[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/8] ide scsi virtio-blk: Reject empty drives un
|
From: |
Christoph Hellwig |
|
Subject: |
[Qemu-devel] Re: [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable |
|
Date: |
Wed, 7 Jul 2010 03:33:35 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Tue, Jul 06, 2010 at 02:37:44PM +0200, Markus Armbruster wrote:
> Disks without media make no sense. For SCSI, a Linux guest kernel
> complains during boot. I didn't try other combinations.
>
> scsi-generic doesn't need the additional check, because it already
> requires bdrv_is_sg(), which fails without media.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure, (continued)
- [Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 8/8] block: Remove type hint, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 7/8] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable, Markus Armbruster, 2010/07/06
- [Qemu-devel] Re: [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 5/8] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 2/8] virtio-blk: Fix virtio-blk-s390 to require drive, Markus Armbruster, 2010/07/06
- [Qemu-devel] Re: [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more, Kevin Wolf, 2010/07/12