[Qemu-devel] Re: [PATCH, RFC] pci: handle BAR mapping at pci level

[Blue Swirl]

On Wed, Jul 7, 2010 at 5:55 PM, Michael S. Tsirkin <address@hidden> wrote:
> On Wed, Jul 07, 2010 at 05:53:08PM +0000, Blue Swirl wrote:
>> Add I/O port registration functions which separate registration
>> from the mapping stage.
>>
>> Move IOIO and MMIO BAR mapping to pci.c.
>>
>> TODO: fix dirty logging, coalesced MMIO and base address comparisons
>> (eepro100 etc). Bridge filtering may be broken. Broke virtio-pci and MSIX.
>
> legacy vga regions too?

Probably not, because VGA still works nicely at PC boot.

>
>> Signed-off-by: Blue Swirl <address@hidden>
>
> Looks like a good direction to take.
>
>> ---
>> i386 boots but resets. PPC and Sparc64 can't even start.
>>
>> Patch also available at
>> git://repo.or.cz/qemu/blueswirl.git
>>
>> It may be worthwhile to break this into some kind of smaller steps.
>
> Definitely.
>

One way could be to leave map_func in place but if it's NULL, use
newer system. When all callers have converted cleanly, remove extra
NULL argument and map_func.

It would be nice to have some plan how to convert KVM stuff like dirty
logging and coalescing. Any ideas?