[Qemu-devel] Re: [PATCH v2 0/5] pci: split out bridge code into pci_bridge and make it library

[Michael S. Tsirkin]

On Mon, Jul 12, 2010 at 07:36:39PM +0900, Isaku Yamahata wrote:
> changes v1 -> v2:
> - introduce pci_internals.h to accomodate pci internal strcutures to
>   share between pci.c and pci_bridge.c
> - don't make PCIBridge::bus pointer as suggested by
>   Michael S. Tsirkin <address@hidden>
> - rename PCIBridge::bus -> PCIBridge::sec_bus
> - eliminate pci_reguster_secondary_bus()/pci_unregister_secondary_bus()
> - document pci bridge library functions.
> - introduced pci bridge library.

I've applied patches 1-4 to make it easier to build upon.
Pushed in pci branch in my tree.
Sent comments on patch 5.

> Clean up of pci host bus ans piix pci as discussed with v1
> will be addressed after this patch set is accepted.
> 
> Patch description:
> Now pci.c has grown. So split bridge related code into dedicated file
> for further extension to pci bridge. Further clean up and pcie port emulator. 
> This make patch conflict less possible in future.
> 
> Isaku Yamahata (5):
>   pci: move out pci internal structures, PCIBus, PCIBridge, and
>     pci_bus_info.
>   pci/bridge: split out pci bridge code into pci_bridge.c from pci.c
>   pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.
>   pci_bridge: clean up: remove pci_{register,
>     unregister}_secondary_bus()
>   pci_bridge: introduce pci bridge library.
> 
>  Makefile.objs      |    2 +-
>  hw/apb_pci.c       |   43 ++++++---
>  hw/dec_pci.c       |   35 ++++++--
>  hw/pci.c           |  207 +------------------------------------------
>  hw/pci.h           |    5 +-
>  hw/pci_bridge.c    |  249 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/pci_bridge.h    |   62 +++++++++++++
>  hw/pci_internals.h |   42 +++++++++
>  qemu-common.h      |    1 +
>  9 files changed, 416 insertions(+), 230 deletions(-)
>  create mode 100644 hw/pci_bridge.c
>  create mode 100644 hw/pci_bridge.h
>  create mode 100644 hw/pci_internals.h