[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devic
From: |
Miguel Di Ciurcio Filho |
Subject: |
[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices |
Date: |
Fri, 16 Jul 2010 11:39:25 -0300 |
On Fri, Jul 16, 2010 at 3:34 AM, Jan Kiszka <address@hidden> wrote:
>
>> - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on
>
> Let the sending peer report (offset field or callback) where to find the
> payload in a frame.
>
Looking further, do you mean what net.c:vc_sendv_compat() does?
> That channel - or a separate one - could also be used to detect if a
> peer supports dumping at all (vhost...). Then no peer code need to be
> extended with dump management code, all could be moved into net.c
>
What do you mean by channel? (sorry, I'm kinda new around here :-)
I don't see how to put everything into net.c. Options parsing/setting
go inside each backend that adds a NetClientDump instance (just a few
lines as seen in my patch on net/tap.c as example), and when packets
come through net.c (qemu_deliver_packet_*()) we get them, right?
Regards,
Miguel
- [Qemu-devel] [PATCH RFC 0/4] Dumping traffic when using netdev devices, Miguel Di Ciurcio Filho, 2010/07/15
- [Qemu-devel] [PATCH RFC 1/4] net/dump: Make pcap structures public, Miguel Di Ciurcio Filho, 2010/07/15
- [Qemu-devel] [PATCH RFC 2/4] net: Introduce NetClientDump and auxiliary functions, Miguel Di Ciurcio Filho, 2010/07/15
- [Qemu-devel] [PATCH RFC 3/4] net/tap: Suggested support for NetClientDump, Miguel Di Ciurcio Filho, 2010/07/15
- [Qemu-devel] [PATCH RFC 4/4] net/slirp: Suggested support for NetClientDump, Miguel Di Ciurcio Filho, 2010/07/15
- [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices, Jan Kiszka, 2010/07/16
- [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices,
Miguel Di Ciurcio Filho <=
- [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices, Anthony Liguori, 2010/07/16
- [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices, Jan Kiszka, 2010/07/16