[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] fw_cfg: Add blit operation for copying kern
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] fw_cfg: Add blit operation for copying kernel, initrd, .. |
|
Date: |
Sun, 18 Jul 2010 22:12:06 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Jul 18, 2010 at 10:47:27PM +0200, Alexander Graf wrote:
> > + if (blitaddr == 0)
> > + ret = 0; /* guest must set up a blit address beforehand */
>
> Coding style. I'm also not sure this has to be special-cased. Why care if the
> guest wants to corrupt its own address space?
>
I agree that we don't need to special-case this. But what was the
coding style issue? (the comment?)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
- [Qemu-devel] [PATCH 0/2] fw_cfg: Implement fast "blit" operation for rapidly copying in kernel, initrd [etc] into the guest, Richard W.M. Jones, 2010/07/17
- [Qemu-devel] [PATCH 1/2] Don't call fw_cfg e->callback if e->callback is NULL., Richard W.M. Jones, 2010/07/17
- [Qemu-devel] [PATCH 2/2] fw_cfg: Add blit operation for copying kernel, initrd, .., Richard W.M. Jones, 2010/07/17
- Re: [Qemu-devel] [PATCH 2/2] fw_cfg: Add blit operation for copying kernel, initrd, .., Aurelien Jarno, 2010/07/18
[Qemu-devel] [PATCH 0/2 version 2] fw_cfg: Implement fast "DMA"-type operation for rapidly copying in kernel, initrd [etc] into the guest, Richard W.M. Jones, 2010/07/19