[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Disable O_DIRECT for physical CDROM/DVD drives
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH] Disable O_DIRECT for physical CDROM/DVD drives |
Date: |
Tue, 20 Jul 2010 18:48:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 07/20/10 18:45, Natalia Portillo wrote:
> El 20/07/2010, a las 16:17, address@hidden escribió:
>
>> From: Jes Sorensen <address@hidden>
>>
>> O_DIRECT (cache=none) requires sector alignment, however the physical
>> sector size of CDROM/DVD drives is 2048, as opposed to most disk
>> devices which use 512. QEMU is hard coding 512 all over the place, so
>> allowing O_DIRECT for CDROM/DVD devices does not work.
>
> What about if the device is a 4096 byte/sector hard disk, a 512 byte/sector
> CD-ROM (IRIX ones), a 2048 byte/sector magnetooptical?
>
> We should get rid of that hard codes and use real values.
I totally agree! However for now my patch throws an error for the CDROM
case, which is better than the old situation. We need to fix it in
general, but it isn't trivial. The 4096 sector size hard disk going to
be the main issue.
Jes
Re: [Qemu-devel] [PATCH] Disable O_DIRECT for physical CDROM/DVD drives, Natalia Portillo, 2010/07/20