[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives |
|
Date: |
Wed, 21 Jul 2010 09:47:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 07/20/10 19:19, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
>
>> On 07/20/10 18:35, David S. Ahern wrote:
>>> On 07/20/10 10:09, address@hidden wrote:
>>> If a cdrom is added via the monitor this would abruptly terminate the VM
>>> - which is not good.
>>
>> True, but this would only happen if the user explicitly marks it
>> cache=none which is not the default value for a new drive, so it would
>> be a corner case.
>
> Why not return -ENOTSUP?
Good point, just posted v3 of the patch that does this instead of exit()
Jes