qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] savevm: Fix memory leak of compat struct


From: Alex Williamson
Subject: [Qemu-devel] [PATCH] savevm: Fix memory leak of compat struct
Date: Wed, 21 Jul 2010 08:35:31 -0600
User-agent: StGIT/0.14.3

Forgot to check for and free these.

Found-by: Zachary Amsden <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
---

 0.13 Candidate

 savevm.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/savevm.c b/savevm.c
index ee27989..1612794 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1126,6 +1126,9 @@ void unregister_savevm(DeviceState *dev, const char 
*idstr, void *opaque)
     QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) {
         if (strcmp(se->idstr, id) == 0 && se->opaque == opaque) {
             QTAILQ_REMOVE(&savevm_handlers, se, entry);
+            if (se->compat) {
+                qemu_free(se->compat);
+            }
             qemu_free(se);
         }
     }
@@ -1193,6 +1196,9 @@ void vmstate_unregister(DeviceState *dev, const 
VMStateDescription *vmsd,
     QTAILQ_FOREACH_SAFE(se, &savevm_handlers, entry, new_se) {
         if (se->vmsd == vmsd && se->opaque == opaque) {
             QTAILQ_REMOVE(&savevm_handlers, se, entry);
+            if (se->compat) {
+                qemu_free(se->compat);
+            }
             qemu_free(se);
         }
     }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]