Re: [Qemu-devel] [PATCH] virtio-serial: Fix compat property name

[Aurelien Jarno]

On Wed, Jun 23, 2010 at 10:49:20PM +0530, Amit Shah wrote:
> Starting with qemu -M pc-0.12 -device virtio-serial
> 
> results in
> 
> -device virtio-serial: Property 'virtio-serial-pci.max_nr_ports' not found
> 
> The property name 'max_ports' is incorrectly named 'max_nr_ports'. Fix
> that.
> 
> Also fix the ppc440 machine type bamboo-0.12 which has this typo.
> 
> Reported-by: Daniel P. Berrange <address@hidden>
> Signed-off-by: Amit Shah <address@hidden>
> ---
>  hw/pc_piix.c       |    6 +++---
>  hw/ppc440_bamboo.c |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)

Thanks, applied.

> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 68040b7..84e6c7f 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -222,7 +222,7 @@ static QEMUMachine pc_machine_v0_12 = {
>      .compat_props = (GlobalProperty[]) {
>          {
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> @@ -245,7 +245,7 @@ static QEMUMachine pc_machine_v0_11 = {
>              .value    = stringify(0),
>          },{
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> @@ -284,7 +284,7 @@ static QEMUMachine pc_machine_v0_10 = {
>              .value    = stringify(PCI_CLASS_DISPLAY_OTHER),
>          },{
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c
> index 6ca873e..d471d5d 100644
> --- a/hw/ppc440_bamboo.c
> +++ b/hw/ppc440_bamboo.c
> @@ -186,7 +186,7 @@ static QEMUMachine bamboo_machine_v0_12 = {
>      .compat_props = (GlobalProperty[]) {
>          {
>              .driver   = "virtio-serial-pci",
> -            .property = "max_nr_ports",
> +            .property = "max_ports",
>              .value    = stringify(1),
>          },{
>              .driver   = "virtio-serial-pci",
> -- 
> 1.7.0.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net