[Qemu-devel] Re: [PATCH] vhost_dev_unassign_memory() don't assert if removing first entry in list.

[Michael S. Tsirkin]

On Fri, Jul 23, 2010 at 05:16:42PM +0200, address@hidden wrote:
> From: Jes Sorensen <address@hidden>
> 
> If removing an entry from the list which is fully included in the
> region and this is the first entry in the list. In this case 'to' can
> go to -1, which is perfectly valid. Don't assert() on this case.
> 
> Signed-off-by: Jes Sorensen <address@hidden>
> ---
>  hw/vhost.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/vhost.c b/hw/vhost.c
> index d37a66e..f30cf91 100644
> --- a/hw/vhost.c
> +++ b/hw/vhost.c
> @@ -119,7 +119,6 @@ static void vhost_dev_unassign_memory(struct vhost_dev 
> *dev,
>          if (start_addr <= reg->guest_phys_addr && memlast >= reglast) {
>              --dev->mem->nregions;
>              --to;
> -            assert(to >= 0);
>              ++overlap_middle;
>              continue;
>          }

Good catch.
I think I must have meant dev->mem->nregions >= 0.  Does this work
if you put in that assertion, or did I miss something else?

> -- 
> 1.7.1.1