qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus initialization c


From: Michael S. Tsirkin
Subject: [Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus initialization clean up.
Date: Mon, 26 Jul 2010 14:33:30 +0300
User-agent: Mutt/1.5.20 (2009-12-10)

> +/*
> + * TODO: there remains some boards which doesn't use PCIHostState.
> + *       Enhance PCIHostState API and convert remaining boards.

I think I remember this comment from Paul:
        On Tuesday 12 January 2010, Isaku Yamahata wrote:
        > To use pci host framework, use PCIHostState instead of PCIBus in      
                                          
        >  PCIVPBState.                                                         
                                          

        No.

        pci_host.[ch] provides very specific functionality, it is not a generic
        PCI host device. Specifically it provides indirect access to PCI config
        space via a memory mapped {address,data} pair. The versatile PCI host 
exposes PCI
        config space directly, so should not be using this code.

        If you want a generic framework for PCI hosts then you need to use
        something else. If nothing else, assuming that a PCI host bridge is 
always is
        SysBus device is wrong.

Still applies?

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]