Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

[Bruce Rogers]

 >>> On 7/27/2010 at 04:26 AM, "Daniel P. Berrange" <address@hidden> wrote: 
> On Wed, Jul 21, 2010 at 02:32:28PM -0600, Bruce Rogers wrote:
>> Libvirt parses qemu help output to determine qemu features. In particular
>>  it probes for the following: "cache=writethrough|writeback|none". The
>>  addition of the unsafe cache mode was inserted within this string, as
>>  opposed to being added to the end, which impacted libvirt's probe.
>>  Unbreak libvirt by keeping the existing cache modes intact and add
>>  unsafe to the end.
> 
> We have inverted the check we made so that instead of doing a positive
> check for the new syntax, we do a negative check for the old syntax,
> avoiding this problem. Of couse any existing deployed livirt will still
> be broken with latest QEMU, but the previous QEMU version string change
> mean that is already the case for any libvirt < 0.8.2
> 
> Daniel


This seems like a quite reasonable resolution to me.

Thanks!

Bruce