Re: [Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c

[Edgar E. Iglesias]

On Tue, Jul 27, 2010 at 10:25:26AM -0700, Richard Henderson wrote:
> A re-based and re-tested version of a patch series I
> posted back in April and May.  These cleanups prepare
> elfload.c for loading the VDSO for x86_64.

I got a whitespace warning when applying the patches:
Applying: linux-user: Reduce lseek+reads while loading elf files.
/home/edgar/src/c/qemu/git/qemu/.git/rebase-apply/patch:219: trailing 
whitespace.
/* Read a good amount of data initially, to hopefully get all the 
warning: 1 line adds whitespace errors.


I removed the trailing whitespace and fixed the interpreter less
ELF loading on my side and applied the series.

If there are more issues with the pre-existing realloc malc
commented on, I think those can be handled with follow up patches.

Thanks,
Edgar



> 
> 
> r~
> 
> 
> Richard Henderson (12):
>   linux-user: Handle filesz < memsz for any PT_LOAD segment.
>   Add more DT_* and AT_* constants to qemu's copy of elf.h.
>   linux-user: Reindent elfload.c.
>   linux-user: Reduce lseek+reads while loading elf files.
>   linux-user: Define ELF_DATA generically.
>   linux-user: Clean up byte-swapping in elfload.c.
>   linux-user: Load symbols from the interpreter.
>   linux-user: Improve consistency checking in elf headers.
>   linux-user: Put the stack guard page at the top.
>   linux-user: Remove partial support for a.out interpreters.
>   linux-user: Extract load_elf_image from load_elf_interp.
>   linux-user: Re-use load_elf_image for the main binary.
> 
>  elf.h                  |   44 ++
>  linux-user/elfload.c   | 1791 
> ++++++++++++++++++++----------------------------
>  linux-user/linuxload.c |   17 +-
>  linux-user/qemu.h      |    7 +-
>  4 files changed, 794 insertions(+), 1065 deletions(-)
> 
>