Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

[Aurelien Jarno]

On Sat, Jul 31, 2010 at 08:23:34PM +0400, malc wrote:
> History has shown that this particular rule is unenforcable.
> 
> Signed-off-by: malc <address@hidden>
> ---
>  CODING_STYLE |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 92036f3..e0b5376 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -54,16 +54,17 @@ readers that they are seeing a wrapped version; otherwise 
> avoid this prefix.
>  
>  4. Block structure
>  
> -Every indented statement is braced; even if the block contains just one
> -statement.  The opening brace is on the line that contains the control
> -flow statement that introduces the new block; the closing brace is on the
> -same line as the else keyword, or on a line by itself if there is no else
> -keyword.  Example:
> +The opening brace is on the line that contains the control flow
> +statement that introduces the new block; the closing brace is on the
> +same line as the else keyword, or on a line by itself if there is no
> +else keyword. Example:
>  
>      if (a == 5) {
>          printf("a was 5.\n");
> +        do5stuff();
>      } else if (a == 6) {
>          printf("a was 6.\n");
> +        do6stuff();
>      } else {
>          printf("a was something else entirely.\n");
>      }

I am "neutral" on this particular rule.

OTOH, my opinion is that we really should try to enforce the rules. The
fact that we are humans and make mistakes (some patches not enforcing
all the rules are committed), is not enough to just ignore the rules. If
a rule is not enforceable, it should be removed from CODING_STYLE, not
removed.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net